Skip to content

Conversation

@lapentad
Copy link
Contributor

examples to register repositories for the example series.

NOTE: I did not add any sync information

@nephio-prow nephio-prow bot requested review from liamfallon and timop62 October 21, 2025 12:31
@netlify
Copy link

netlify bot commented Oct 21, 2025

Deploy Preview for nephio ready!

Name Link
🔨 Latest commit 67481cc
🔍 Latest deploy log https://app.netlify.com/projects/nephio/deploys/691ef615dced780008fe5640
😎 Deploy Preview https://deploy-preview-278--nephio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

lapentad and others added 3 commits October 28, 2025 12:02
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
…ositories.md

Co-authored-by: Fiachra Corcoran <fiachra.corcoran@est.tech>
…ositories.md

Co-authored-by: Fiachra Corcoran <fiachra.corcoran@est.tech>
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
…epositories.md

Co-authored-by: Catalin Stratulat <159934629+Catalin-Stratulat-Ericsson@users.noreply.github.com>
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
lapentad and others added 2 commits October 31, 2025 14:16
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
…epositories.md

Co-authored-by: Catalin Stratulat <159934629+Catalin-Stratulat-Ericsson@users.noreply.github.com>
# Setting Up Repositories

tutorial in setting up porch repositories and using them
Before Porch can manage packages, you must register the Git repositories where those packages are stored. This tells Porch where to find package blueprints and where to store deployment packages.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use the term "packages" a lot in the docs. Do we need to point to a "kpt package" definition somewhere just to be clear?
Also, having this as a prerequisite would suffice for me.

  • A Git repository containing your KPT packages

Or do we have a tutorial to "Set up a Git repo with dummy KPT package".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no i want to veer away from this if possible. we make it extremely clear in the concepts section here

* ***Package***: A package, in Porch, is specifically a [kpt package](https://kpt.dev/) - a collection of related YAML
files including one or more **[KRM resources][krm]** and a [Kptfile](https://kpt.dev/book/02-concepts/#packages).
{{% alert title="N.B." color="warning" %}}
There is no such thing as a "Porch Package" - rather, **Porch stores and orchestrates kpt packages**.
{{% /alert %}}
and soon in the overview also that there is no such thing as porch packages and from that point on packages means kpt packages

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think we should foster this. i see it the same way as mentioning configuration as data. having its acronym stated as CaD and from that point on you refer to it as CaD and if someone does not know what that means they should go to its definition rather than carrying the explanation throughout the entire documentation for those who did not read that section. same with stating oci as experimental. we state that once clearly and explain why it is etc and then from that point on we only really mention git repositories.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but thats just my opinion. if people disagree we can have a discussion and change it

Signed-off-by: lapentafd <francesco.lapenta@est.tech>
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
@sonarqubecloud
Copy link

@lovesprung
Copy link
Contributor

/approve

@nephio-prow nephio-prow bot added the approved label Nov 20, 2025
@Catalin-Stratulat-Ericsson
Copy link
Contributor

/approve this looks ready to go in for me.

@nephio-prow
Copy link
Contributor

nephio-prow bot commented Nov 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Catalin-Stratulat-Ericsson, lovesprung

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Catalin-Stratulat-Ericsson,lovesprung]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Comment on lines +38 to +47
# Register a Git repository with Porch
porchctl repo register http://gitea.gitea:3000/nephio/porch-test.git \
--name=porch-test \
--description="Test repository for Porch packages" \
--branch=main \
--deployment=true \
--repo-basic-username=nephio \
--repo-basic-password=secret
```

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now that i think of it this shows input and no output.
we should include the response of a repo get command and show a successfully registered repo and an unsuccessful registration

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe even a FAQ of common registration issues reason for repo not being ready e.g. invalid password/username combo etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants