Skip to content

Adding Porch definition #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adding Porch definition #283

wants to merge 2 commits into from

Conversation

@CsatariGergely
Copy link
Contributor

@CsatariGergely CsatariGergely commented Nov 6, 2025 •
edited
Loading

No description provided.

@CsatariGergely @lovesprung @timop62
Adding Porch definition
46bc98e 
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Co-authored-by: Dominika Schweier <dominika.schweier@nokia.com>
Co-authored-by:Michael Greaves <michael.greaves@nokia.com>
Co-authored-by: Timo Perala <timo.perala@nokia.com>
@netlify
Copy link

netlify bot commented Nov 6, 2025 •
edited
Loading

✅ Deploy Preview for nephio ready!

Name Link
🔨 Latest commit d069752
🔍 Latest deploy log https://app.netlify.com/projects/nephio/deploys/691ee263fd23700008a87708
😎 Deploy Preview https://deploy-preview-283--nephio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@CsatariGergely
Copy link
Contributor Author

CsatariGergely commented Nov 6, 2025

/assign @Catalin-Stratulat-Ericsson @ciaranjohnston @liamfallon @efiacor

@Catalin-Stratulat-Ericsson
Copy link
Contributor

Catalin-Stratulat-Ericsson commented Nov 10, 2025

the original content in this section was meant as a lorem ipsum filler and not to actually be used as a overview section text and was pushed in here with the document refactor template by mistake. in my opinion i think this section should be done from scratch rather than use the sample text already there.

@CsatariGergely
Removing template text
d069752 
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 20, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@CsatariGergely
Copy link
Contributor Author

CsatariGergely commented Nov 20, 2025

the original content in this section was meant as a lorem ipsum filler and not to actually be used as a overview section text and was pushed in here with the document refactor template by mistake. in my opinion i think this section should be done from scratch rather than use the sample text already there.

Okay, I've removed the template text in d069752

@Catalin-Stratulat-Ericsson
Copy link
Contributor

Catalin-Stratulat-Ericsson commented Nov 20, 2025

/approve but are we going to add a definition in this PR? or are we just removing the "lorem ipsum" filler text?

@nephio-prow
Copy link
Contributor

nephio-prow bot commented Nov 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Catalin-Stratulat-Ericsson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Catalin-Stratulat-Ericsson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

@timop62 timop62 Awaiting requested review from timop62

Assignees

@ciaranjohnston ciaranjohnston

@liamfallon liamfallon

@efiacor efiacor

@Catalin-Stratulat-Ericsson Catalin-Stratulat-Ericsson

Labels

approved porch-doc-refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@CsatariGergely @Catalin-Stratulat-Ericsson @ciaranjohnston @liamfallon @efiacor