-
Notifications
You must be signed in to change notification settings - Fork 181
Enable the use of non-origin oAuth urls + new window options #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hrangel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems perfect to me
|
I think so too. Didn't have time to test it yet. |
|
@neroniaky that will even fix the issue I mentioned in #119 , the issue is with the single quote chars when building the oauth path, it should be ` char so the literal string replacing works. |
|
Thanks. Since the PR was initially opened, I also added an optional I added an optional |
|
Thanks @jookyboi! |
|
👍 |
Enable the use of non-origin oAuth urls + new window options
I have an Angular2 app which uses a separate Rails/Devise backend. I needed the oAuth flow to hit that server rather than the host which serves my frontend client. This pull helps deal with that.
oAuthBaseoption for the oAuth flowapiBaseoption for other API callsoAuthWindowOptionsto allow users to set additional options on the new window (ex.oAuthWindowOptions: { width: '800', height: '600' })Thanks for taking the lead on an excellent package.