Skip to content

Conversation

@jookyboi
Copy link

@jookyboi jookyboi commented Dec 28, 2016

I have an Angular2 app which uses a separate Rails/Devise backend. I needed the oAuth flow to hit that server rather than the host which serves my frontend client. This pull helps deal with that.

  • Added new oAuthBase option for the oAuth flow
  • Added new apiBase option for other API calls
  • Added a [string:string] object oAuthWindowOptions to allow users to set additional options on the new window (ex. oAuthWindowOptions: { width: '800', height: '600' })
  • I switched to using backticks for strings which have variable interpolation. It didn't compile with just straight up single-quotes for me
  • Updated docs

Thanks for taking the lead on an excellent package.

@jookyboi jookyboi closed this Jan 2, 2017
Copy link
Contributor

@hrangel hrangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems perfect to me

@neroniaky
Copy link
Owner

I think so too. Didn't have time to test it yet.

@hrangel
Copy link
Contributor

hrangel commented Jan 13, 2017

@neroniaky that will even fix the issue I mentioned in #119 , the issue is with the single quote chars when building the oauth path, it should be ` char so the literal string replacing works.

@neroniaky neroniaky reopened this Jan 13, 2017
hrangel pushed a commit to hrangel/angular2-token that referenced this pull request Jan 13, 2017
@jookyboi
Copy link
Author

jookyboi commented Jan 13, 2017

Thanks. Since the PR was initially opened, I also added an optional resetPasswordToken to updatePassword() so that users going through the Devise reset-password flow could update their password.

I added an optional name? as well to the RegisterData model since I needed it for display.

@neroniaky neroniaky merged commit a99b748 into neroniaky:master Jan 14, 2017
@neroniaky
Copy link
Owner

Thanks @jookyboi!

@jookyboi
Copy link
Author

👍

neroniaky added a commit that referenced this pull request Jun 19, 2022
Enable the use of non-origin oAuth urls + new window options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants