Angular Universal Compatibility for Server Side Rendering #474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Conditionally mock the reference to the window object while rendering on the server side - Removed unused import specifier tap
Owner
|
@xthilakx Thanks! |
Contributor
Author
|
Thanks for accepting my pull request! |
Contributor
Author
|
@neroniaky @arjenbrandenburgh Would it be possible to publish a patch release on npm which includes this pull request? |
Owner
|
@xthilakx gonna release a new version today. |
neroniaky
added a commit
that referenced
this pull request
Jun 19, 2022
Angular Universal Compatibility for Server Side Rendering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #470
What is the new behavior?
Angular Universal Compatibility for Server Side Rendering
Does this PR introduce a breaking change?
Other information
I tried looking, but could not find one.
Since tests run on a headless browser, I'm not sure how to mock the environment