Support WASM #55
Merged
Support WASM #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Officeyutong
reviewed
Sep 3, 2025
wasm/src/lib.rs
Outdated
| h256_to_str(h) | ||
| } | ||
|
|
||
| pub fn update(&mut self, key: &str, val: &str) { |
There was a problem hiding this comment.
In rust str is only designed to hold a valid utf-8 string, what if a user want to hash a Uint8Array?
wasm/src/lib.rs
Outdated
| } | ||
|
|
||
| fn parse_leaves(leaves: wasm_bindgen::JsValue) -> Vec<(H256, H256)> { | ||
| let leaves = leaves.dyn_ref::<js_sys::Array>(); |
There was a problem hiding this comment.
We may use serde_wasm_bindgen to deserialize JS objects to Rust objects
XuJiandong
requested changes
Sep 4, 2025
wasm/src/lib.rs
Outdated
| type Smt = SparseMerkleTree<CkbBlake2bHasher, H256, DefaultStore<H256>>; | ||
|
|
||
| #[wasm_bindgen] | ||
| pub fn hash_data(d: wasm_bindgen::JsValue) -> Uint8Array { |
Collaborator
There was a problem hiding this comment.
support d with type 'Uint8Array'. Rename this function name to blake2b_256
XuJiandong
approved these changes
Sep 11, 2025
quake
reviewed
Sep 15, 2025
quake
approved these changes
Sep 16, 2025
Merged
via the queue into
nervosnetwork:master
with commit Sep 16, 2025
b74ea1b
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.