Upstream mpi comm #121
Merged
Upstream mpi comm #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhnnsnk
reviewed
Oct 8, 2024
Collaborator
jhnnsnk
left a comment
jhnnsnk
left a comment
There was a problem hiding this comment.
Thanks for this PR. There are a couple of lines just commented out, could they be removed? Otherwise I approve.
Collaborator
Author
|
The code actually contains several places with such commented lines, for now I would propose to merge to this development branch and before merging back to main we should spend some time doing the cleanup. |
jhnnsnk
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged Bruno's mpi_comm with upstream nest-gpu-2.0-mpi-comm