Skip to content

Conversation

@emibloque
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[x] Other... Please describe: **Documentation update**.

What is the current behavior?

The Middleware documentation for Routing Matching is the same as in Controllers, but the code example isn't the same.

What is the new behavior?

It is easier to understand the example and the behaviour of the asterisk in route matching.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@emibloque emibloque force-pushed the fix-middleware-example branch from 67663f0 to 72a8ec6 Compare October 16, 2018 14:04
@emibloque emibloque changed the title Update routeWildcards snippet to match example (docs): Update code snippet to match example Oct 16, 2018
@kamilmysliwiec
Copy link
Member

Thanks!

@kamilmysliwiec kamilmysliwiec merged commit 8dbd24b into nestjs:master Oct 19, 2018
@emibloque emibloque deleted the fix-middleware-example branch October 19, 2018 23:25
duard pushed a commit to duard/docs.nestjs.com that referenced this pull request Apr 4, 2023
content: update code snippet to match example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants