Skip to content

Commit c9f1ee7

Browse files
committed
fix(): useFactory options type and eslint
1 parent d24e5b6 commit c9f1ee7

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

lib/interfaces/mongoose-options.interface.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,15 @@ export interface MongooseOptionsFactory {
1818
| MongooseModuleOptions;
1919
}
2020

21+
export type MongooseModuleOptionsFactory = Omit<MongooseModuleOptions, 'connectionName'>
22+
2123
export interface MongooseModuleAsyncOptions
2224
extends Pick<ModuleMetadata, 'imports'> {
2325
connectionName?: string;
2426
useExisting?: Type<MongooseOptionsFactory>;
2527
useClass?: Type<MongooseOptionsFactory>;
2628
useFactory?: (
2729
...args: any[]
28-
) => Promise<MongooseModuleOptions> | MongooseModuleOptions;
30+
) => Promise<MongooseModuleOptionsFactory> | MongooseModuleOptionsFactory;
2931
inject?: any[];
3032
}

lib/mongoose-core.module.ts

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable @typescript-eslint/no-unused-vars */
21
import {
32
DynamicModule,
43
Global,
@@ -15,6 +14,7 @@ import { getConnectionToken, handleRetry } from './common/mongoose.utils';
1514
import {
1615
MongooseModuleAsyncOptions,
1716
MongooseModuleOptions,
17+
MongooseModuleOptionsFactory,
1818
MongooseOptionsFactory,
1919
} from './interfaces/mongoose-options.interface';
2020
import {
@@ -84,12 +84,11 @@ export class MongooseCoreModule implements OnApplicationShutdown {
8484
const connectionProvider = {
8585
provide: mongooseConnectionName,
8686
useFactory: async (
87-
mongooseModuleOptions: MongooseModuleOptions,
87+
mongooseModuleOptions: MongooseModuleOptionsFactory,
8888
): Promise<any> => {
8989
const {
9090
retryAttempts,
9191
retryDelay,
92-
connectionName,
9392
uri,
9493
connectionFactory,
9594
...mongooseOptions
@@ -100,7 +99,7 @@ export class MongooseCoreModule implements OnApplicationShutdown {
10099

101100
return await defer(async () =>
102101
mongooseConnectionFactory(
103-
mongoose.createConnection(mongooseModuleOptions.uri as string, {
102+
mongoose.createConnection(uri as string, {
104103
useNewUrlParser: true,
105104
useUnifiedTopology: true,
106105
...mongooseOptions,
@@ -110,8 +109,8 @@ export class MongooseCoreModule implements OnApplicationShutdown {
110109
)
111110
.pipe(
112111
handleRetry(
113-
mongooseModuleOptions.retryAttempts,
114-
mongooseModuleOptions.retryDelay,
112+
retryAttempts,
113+
retryDelay,
115114
),
116115
)
117116
.toPromise();

0 commit comments

Comments
 (0)