add _version_sanitize and improve _version_check_greater in netbox_utils #1491
+85
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add _version_sanitize - add unit test for _version_sanitize - netbox-version can sometimes be 4.2.9-Docker-3.2.1 but expecting full_version is just 4.2.9 do not see any purpose Docker-3.2.1 so sanitize netbox version - sanitize api version - just for sure. no issues yet
3 tasks
- allow compare even 3 digit versions or more - sanitize inputs - full_version can sometimes be 4.2.9-Docker-3.2.1 just use only 4.2.9 - extend unit tests
cernymi
force-pushed
the
cernymi/netbox_versions
branch
from
3ab35cf to
1e2bdc3
Compare
sc68cal
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
None
New Behavior
None
...
Contrast to Current Behavior
Values from
netbox-versionandnb.versionare now sanitized.For example, a version like
4.2.9-Docker-3.2.1is correctly handled as4.2.9.The
_version_check_greaterfunction is now more versatile, supporting comparisons of versions with more than two numeric components (e.g.,2.10.3vs2.9.12or even2.10vs2.10.2)....
Discussion: Benefits and Drawbacks
Plus:
netbox-versionandnb.version_version_check_greaterfunction...
Changes to the Documentation
None
...
Proposed Release Note Entry
...
Double Check
develbranch.