-
Notifications
You must be signed in to change notification settings - Fork 12
Support e2e tests against multiple NetBox versions #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
23adae8 to
3e98547
Compare
3e98547 to
845ad6c
Compare
|
To test this locally, execute |
845ad6c to
c52c6c3
Compare
e58e9ab to
b96d814
Compare
7338114 to
bd311b6
Compare
Fix issue with podman Remove exit(1)
bd311b6 to
0cfa2ea
Compare
|
@alexandernorth PTAL thank you :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is ok to merge as it is, but we should probably revisit the best way to handle multiple version services in the future
I will create an issue to track this. Thank you @alexandernorth :) |
(Reopen #167. Due to PR base branch setting errors, I can't reopen the original PR...)
Since we are introducing the e2e test and running against real NetBox instances, it makes sense to test against different versions of NetBox, so we can flag issues early on.
CI will now run all e2e tests against the supported versions.
The supported NetBox versions are (the latest patch version for the
major.minorrelease):Instead of
create-kind, we now havecreate-kind-3.7.8,create-kind-4.0.11, andcreate-kind-4.1.8. The same goes formake test-e2e.The patching mechanism is used to apply database schema fixes and demo data version changes. When we introduce support for new versions, usually only the database schema would need to be changed.
Blocked by #175 (#177)