Trigger reconciliation of owner if change in controlled resource is detected

[bruelea]

Before this change the reconciliation of a claim resource wasn't triggered if a change was detected in the owned resource because of the missing controller reference in the owner reference

Changes:
Use an owner reference with a reference to a controller
Remove status update which is no longer needed in ip address claim controller test
Remove unused functions from prefix claim type

[henrybear327]

@bruelea I think there are 2 extra SetOwnerReferences left there

• in

  netbox-operator/internal/controller/ipaddress_controller_test.go

  Line 267 in 798a308

  Expect(controllerutil.SetOwnerReference(ipccr, ipcr, scheme.Scheme)).Should(Succeed())

  that needs to be changed.
• in

  netbox-operator/api/v1/prefixclaim_types.go

  Line 126 in 798a308

  prefixResource.SetOwnerReferences(owner)

  . It's an unused function though, maybe we can just remove the function?

More SetOwnerReferences spotted in the code

[bruelea]

@bruelea I think there are 2 extra SetOwnerReferences left there

• in

  netbox-operator/internal/controller/ipaddress_controller_test.go

  Line 267 in 798a308

  Expect(controllerutil.SetOwnerReference(ipccr, ipcr, scheme.Scheme)).Should(Succeed())

  
  that needs to be changed.
• in

  netbox-operator/api/v1/prefixclaim_types.go

  Line 126 in 798a308

  prefixResource.SetOwnerReferences(owner)

  
  . It's an unused function though, maybe we can just remove the function?

Good catch! I removed the unused functions and replaced the function in the controller test.