Add step to e2e tests to clean up resources in the test NetBox instance #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstudler
approved these changes
Jun 19, 2025
Collaborator
jstudler
left a comment
jstudler
left a comment
There was a problem hiding this comment.
This works great! Thanks for finding this trick, didn't think of it before...
vaishutin
pushed a commit
to vaishutin/netbox-operator
that referenced
this pull request
Aug 17, 2025
…ce (netbox-community#321) * add clean up to first test * add clean up to all tests * Add a few notes on how to work with tests --------- Co-authored-by: Joel Studler <joel.studler@swisscom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #250
The added step sets the preserveInNetbox field to false and waits until the child resources have status condition 'Ready' true with the expected observedGeneration.
Note: the cleanup of the resources in NetBox only works if the tests succeed. In the future a script can be added that runs when all tests are completed and cleans all resources from NetBox which were created by the tests.
Idea is based on #248.