Change Record._endpoint_from_url() to handle stripped http/https default ports #310
+45
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #309 (that was caused by the parsing change in #308)
NetBox removes the default http/https (80 or 443 respectively) port from the response object URL even though it is given for any reason in the
pynetbox.Apiinstantiation. That makesRecord._endpoint_from_url()generate incorrectAppnames (it removes too many characters from the given URL) in those cases.This PR makes
Record._endpoint_from_url()to remove the default ports so that theAppname is correctly parsed. Parsing does not look very elegant but works 😐