Skip to content

Conversation

@mfiedorowicz
Copy link
Member

This pull request includes several changes to update dependencies, remove unused code, and refactor validation logic in the netbox_diode_plugin project. The most important changes include updating the Docker image versions, refactoring the diode_target_validator function, and removing the Reconciler SDK.

Dependency Updates:

  • Updated the Docker image version in docker/Dockerfile-diode-netbox-plugin to v4.1.11-3.0.2.
  • Updated the Docker image version in docker/docker-compose.yaml to v4.1.11-3.0.2-diode-netbox-plugin.

Code Refactoring:

  • Refactored the diode_target_validator function in netbox_diode_plugin/models.py to use urlparse directly instead of parse_target.

Code Removal:

  • Removed the Reconciler SDK and related files, including netbox_diode_plugin/reconciler/__init__.py, netbox_diode_plugin/reconciler/sdk/__init__.py, netbox_diode_plugin/reconciler/sdk/client.py, netbox_diode_plugin/reconciler/sdk/exceptions.py, and netbox_diode_plugin/reconciler/sdk/v1/__init__.py [1] [2] [3] [4] [5].

Simplification:

  • Removed the ingestion_logs menu item from netbox_diode_plugin/navigation.py [1] [2].

Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@github-actions
Copy link

github-actions bot commented Feb 6, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1261 1247 99% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
netbox_diode_plugin/models.py 100% 🟢
netbox_diode_plugin/navigation.py 100% 🟢
netbox_diode_plugin/tests/test_views.py 100% 🟢
netbox_diode_plugin/urls.py 100% 🟢
netbox_diode_plugin/views.py 98% 🟢
TOTAL 100% 🟢

updated for commit: 79a5185 by action🐍

@mfiedorowicz mfiedorowicz merged commit 13115bd into feat-diode-data-plugin Feb 6, 2025
2 checks passed
@mfiedorowicz mfiedorowicz deleted the feat-remove-ingestion-logs branch February 6, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants