Skip to content

feat: update data model #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: feat: diode data plugin 1.0 rc
merged 30 commits into from
Apr 7, 2025
Merged

feat: update data model #73

merged 30 commits into from
Apr 7, 2025
+3,248 −1,893

Conversation

@ltucker
Copy link
Contributor

@ltucker ltucker commented Apr 7, 2025

baseline changes to support updated data model

mfiedorowicz and others added 30 commits April 7, 2025 16:59
@mfiedorowicz @ltucker
fix: scope support on apply change set (#64)
cae961c 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@ltucker
wip diff api
1f0d1df
@mfiedorowicz @ltucker
set default values and missing slugs
a433f3c 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz @ltucker
tidy up setting defaults
4a932b7 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz @ltucker
remove unused imports
c5529e4 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz @ltucker
fix constructor of object type
0c73064 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz @ltucker
set slugs (if not present) after resolving existing instances
0b33e8e 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@ltucker
emit ref_id instead of variable object_id field for new objects
ceabfef
@ltucker
improve entity field mapping coverage
839b684
@ltucker
fill in primary value mapping, use primary value for slug
ab9bbf3
@ltucker
use canonical field ordering in change dicts
753fd69
@ltucker
first pass at certain common circular refs
b59b06a
@mfiedorowicz @ltucker
remove ref id to itself
1a9289e 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz @ltucker
tidy up
a479246 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz @ltucker
add applier
db56ef6 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@ltucker
fix resolve ref before lookup, use field name directly, not field attr
108604e
@ltucker
don't query with unresolved references
6f795c2
@mfiedorowicz @ltucker
fix _build_expressions_queryset
370bf26 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz @ltucker
resolve lint issues
33b2f24 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz @ltucker
exclude fields with GenericRelation type
35e56b0 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz @ltucker
fix sorting dict
d01627c 
we may get ints strings etc

Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz @ltucker
rework applier logic
aaed4f8 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz @ltucker
applier with content type fields
f84158a 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz @ltucker
fix content type related existing value
9769369 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz @ltucker
exclude foreign key fields with many to one rel
2016dc4 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@ltucker
fix: support for post create updates eg (primary mac address) (#68)
0e48f7b 
* fix: support for post create updates eg (primary mac address)

* use serializers, fix relevent tests

* linting

* filter fields in the prior state

* add some basic smoke tests for diff / diff+apply
@ltucker @mfiedorowicz
Change set validation (#69)
8d6c5d1 
* add change set validation

Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>

* remove redundant serializers

Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>

* remove redundant serializers tests

Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>

* tidy up

Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>

* adjust tests, lighter validation of refs on diff, handle generic

---------

Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Co-authored-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@ltucker
fix: expand support for cycle breaking, add additional logical matche…
8f6abfd 
…rs (#70)
@ltucker
fix: fix error fingerprinting tags (#71)
e7235c9
@ltucker
fix: all noops -> no changes, show noops as only prior state (#72)
5a98d6b
@github-actions
Copy link

github-actions bot commented Apr 7, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1852 1721 93% 0% 🟢

New Files

File Coverage Status
netbox_diode_plugin/api/applier.py 88% 🟢
netbox_diode_plugin/api/common.py 92% 🟢
netbox_diode_plugin/api/differ.py 86% 🟢
netbox_diode_plugin/api/matcher.py 84% 🟢
netbox_diode_plugin/api/plugin_utils.py 98% 🟢
netbox_diode_plugin/api/supported_models.py 91% 🟢
netbox_diode_plugin/api/transformer.py 94% 🟢
netbox_diode_plugin/tests/test_api_diff_and_apply.py 100% 🟢
netbox_diode_plugin/tests/test_api_generate_diff.py 100% 🟢
TOTAL 93% 🟢

Modified Files

File Coverage Status
netbox_diode_plugin/api/serializers.py 0% 🟢
netbox_diode_plugin/api/urls.py 100% 🟢
netbox_diode_plugin/api/views.py 74% 🟢
netbox_diode_plugin/tests/test_api_apply_change_set.py 99% 🟢
TOTAL 68% 🟢

updated for commit: 5a98d6b by action🐍

@ltucker ltucker merged commit ce3beeb into feat-diode-data-plugin Apr 7, 2025
3 checks passed
@ltucker ltucker deleted the update_data_model branch April 7, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfiedorowicz mfiedorowicz mfiedorowicz approved these changes

@leoparente leoparente Awaiting requested review from leoparente

Assignees

No one assigned

Labels

dependencies internal python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ltucker @mfiedorowicz