Skip to content

Conversation

@ltucker
Copy link
Contributor

@ltucker ltucker commented Apr 8, 2025

result was returning a change set, but expectation elsewhere was change set inside a field change_set ...

@ltucker
Copy link
Contributor Author

ltucker commented Apr 8, 2025

also @mfiedorowicz I'm not sure about the "outer" id field on the ChangeSetResult structure, should that always match the id of the inner ChangeSet structure found inside change_set or be omitted when a change_set is provided?

@mfiedorowicz
Copy link
Member

mfiedorowicz commented Apr 8, 2025

also @mfiedorowicz I'm not sure about the "outer" id field on the ChangeSetResult structure, should that always match the id of the inner ChangeSet structure found inside change_set or be omitted when a change_set is provided?

In case of errors/exceptions e.g. during diffing there may be no change set ID yet, but the result object should have any kind of ID (tho not sure how useful it may be)

Update: seems redundant after all, we could omit it completely and adjust diode server

@github-actions
Copy link

github-actions bot commented Apr 8, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1853 1722 93% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
netbox_diode_plugin/api/common.py 92% 🟢
netbox_diode_plugin/tests/test_api_diff_and_apply.py 100% 🟢
netbox_diode_plugin/tests/test_api_generate_diff.py 100% 🟢
TOTAL 97% 🟢

updated for commit: 85d15bc by action🐍

@ltucker ltucker merged commit fd79324 into feat-diode-data-plugin Apr 8, 2025
3 checks passed
@ltucker ltucker deleted the fix-result branch April 8, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants