Skip to content

fix: merge tags rather than overwrite #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: feat: diode data plugin 1.0 rc
merged 1 commit into from
Apr 11, 2025
Merged

fix: merge tags rather than overwrite #77

merged 1 commit into from
Apr 11, 2025

Conversation

@ltucker
Copy link
Contributor

@ltucker ltucker commented Apr 11, 2025

  • merges tags rather than overwrite.
  • leaves other multi-reference types as overwrite ... (questionable?)
  • adds test of current behavior
  • fixes issue with deduplicated references
  • add ability to pass arbitrary flags to test rather than target-per-option
  • enable debug logging output in docker

@github-actions
Copy link

github-actions bot commented Apr 11, 2025 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
2277 2109 93% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
netbox_diode_plugin/api/differ.py 94% 🟢
netbox_diode_plugin/api/transformer.py 87% 🟢
netbox_diode_plugin/tests/test_api_diff_and_apply.py 100% 🟢
TOTAL 93% 🟢

updated for commit: 600ec99 by action🐍

mfiedorowicz
mfiedorowicz approved these changes Apr 11, 2025
View reviewed changes
Copy link
Member

@mfiedorowicz mfiedorowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ltucker ltucker merged commit 6275570 into feat-diode-data-plugin Apr 11, 2025
3 checks passed
@ltucker ltucker deleted the merge_tags branch April 11, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfiedorowicz mfiedorowicz mfiedorowicz approved these changes

@leoparente leoparente Awaiting requested review from leoparente

Assignees

No one assigned

Labels

internal python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ltucker @mfiedorowicz