Skip to content

fix: fix complex vm interface update case #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: feat: diode data plugin 1.0 rc
merged 2 commits into from
Apr 13, 2025
Merged

fix: fix complex vm interface update case #82

merged 2 commits into from
Apr 13, 2025
+83 −8

Conversation

@ltucker
Copy link
Contributor

@ltucker ltucker commented Apr 13, 2025

Fixes error discovered updating a complex vminterface structure

@github-actions
Copy link

github-actions bot commented Apr 13, 2025 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
2549 2343 92% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
netbox_diode_plugin/api/differ.py 92% 🟢
netbox_diode_plugin/api/matcher.py 82% 🟢
netbox_diode_plugin/api/transformer.py 88% 🟢
netbox_diode_plugin/tests/test_api_diff_and_apply.py 100% 🟢
TOTAL 90% 🟢

updated for commit: 03db65d by action🐍

mfiedorowicz
mfiedorowicz approved these changes Apr 13, 2025
View reviewed changes
Copy link
Member

@mfiedorowicz mfiedorowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍, minor lint errors detected

@ltucker ltucker merged commit adf151f into feat-diode-data-plugin Apr 13, 2025
3 checks passed
@ltucker ltucker deleted the fix_vminterface_error branch April 13, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfiedorowicz mfiedorowicz mfiedorowicz approved these changes

@leoparente leoparente Awaiting requested review from leoparente

Assignees

No one assigned

Labels

python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ltucker @mfiedorowicz