Skip to content

fix: create and fix failing tests #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: feat: diode data plugin 1.0 rc
merged 17 commits into from
Apr 21, 2025
Merged

fix: create and fix failing tests #87

merged 17 commits into from
Apr 21, 2025
+7,087 −153

Conversation

@ltucker
Copy link
Contributor

@ltucker ltucker commented Apr 21, 2025

  • Adds additional test coverage for most types / fields and other cases
  • Related fixes

ltucker added 17 commits April 21, 2025 09:05
@ltucker
fix: handle callable defaults, defaults with non serializable values
ce88058
@ltucker
fix: mark circuits.provider.accounts as circular
f0fa18c
@ltucker
fix: error deduplicating device types
b3a487e
@ltucker
fix: report merge errors as 400 not 500
76dc855
@ltucker
fix: mark device oob_ip as circular
9af50f6
@ltucker
fix: adjust fingerprint matching for complex module bay case
73b79e8
@ltucker
fix: test virtual machine with primary_ip4 errors, logical cluster ma…
e5e75a0 
…tching
@ltucker
fix: harmonize ZoneInfo values
36481bc
@ltucker
fix: fix logical prefix in vrf lookup
f829ff9
@ltucker
fix: handle IntegrityError nicely
7e87cc8
@ltucker
fix: support cached scope for matching
ab6e6fb
@ltucker
fix: add additional logical matchers
6433e2c
@ltucker
fix: don't alter arrays. output prior states for other ref types
3bb97d0
@ltucker
fix: add table test for create/update of various types
ab5fa87
@ltucker
fix: additional fixes from testing
c8d73f3
@ltucker
fix: reduce logging, guard expensive trace logging with flag
47ee552
@ltucker
fix: linting
2653f48
@ltucker ltucker changed the title Failing tests fix: create and fix failing tests Apr 21, 2025
@github-actions
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
2889 2700 93% 0% 🟢

New Files

File Coverage Status
netbox_diode_plugin/tests/test_updates.py 94% 🟢
TOTAL 94% 🟢

Modified Files

File Coverage Status
netbox_diode_plugin/api/applier.py 93% 🟢
netbox_diode_plugin/api/common.py 90% 🟢
netbox_diode_plugin/api/differ.py 94% 🟢
netbox_diode_plugin/api/matcher.py 87% 🟢
netbox_diode_plugin/api/transformer.py 90% 🟢
netbox_diode_plugin/tests/test_api_diff_and_apply.py 100% 🟢
netbox_diode_plugin/tests/test_api_generate_diff.py 100% 🟢
TOTAL 94% 🟢

updated for commit: 2653f48 by action🐍

@ltucker ltucker merged commit 0d3522a into feat-diode-data-plugin Apr 21, 2025
3 checks passed
@ltucker ltucker deleted the failing_tests branch April 21, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfiedorowicz mfiedorowicz mfiedorowicz approved these changes

@leoparente leoparente Awaiting requested review from leoparente

Assignees

No one assigned

Labels

python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ltucker @mfiedorowicz