Skip to content

Conversation

@mfiedorowicz
Copy link
Member

This pull request includes a change to improve naming consistency and functionality in the _post method of netbox_diode_plugin/api/views.py. The key update involves renaming variables and updating logic to reflect the use of schema_id instead of id for branch identification.

Changes to branch identification logic:

  • Renamed branch_id to branch_schema_id to align with the use of schema_id for branch identification. Updated all relevant references in the _post method.
  • Modified the logic to retrieve a branch using schema_id instead of id and updated the result.change_set.branch structure to include schema_id and name.
  • Adjusted the error logging to sanitize and log branch_schema_id instead of branch_id when a branch does not exist.

Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@github-actions
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
2794 2600 93% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
netbox_diode_plugin/api/views.py 79% 🟢
TOTAL 79% 🟢

updated for commit: 16e2a14 by action🐍

@ltucker ltucker merged commit 886d916 into develop Apr 24, 2025
6 checks passed
@ltucker ltucker deleted the fix-generate-diff-branch branch April 24, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants