feat: add support for extra volumes and volume mounts in pods #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RangerRick
requested review from
MicahParks,
jajeffries,
leoparente,
ltucker and
mfiedorowicz
as code owners
RangerRick
force-pushed
the
feat/extra_volumes
branch
from
52830b9 to
c106390
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: add support for configuring volumes and volume mounts added to the various diode pods. This is to support mounting secrets or other data, for example to provide a cert and key to be used for mTLS with external Redis.
This pull request updates the Diode Helm chart to version 1.11.0 and introduces new configuration options to support custom volume mounts and volumes for the Auth, Ingester, Reconciler, and Auth Bootstrap components. These enhancements provide greater flexibility for mounting additional files or secrets into the relevant containers and jobs.
Key changes:
Feature: Additional Volume and VolumeMount Support
extraVolumesandextraVolumeMountsoptions todiodeAuth,diodeIngester,diodeReconciler, anddiodeAuthBootstrap.jobinvalues.yamlto allow users to specify custom volumes and mounts via Helm values. [1] [2] [3] [4]diode-auth-deployment.yaml,diode-ingester-deployment.yaml,diode-reconciler-deployment.yaml,diode-auth-bootstrap-job.yaml) to render these new volume and mount definitions when provided. [1] [2] [3] [4]Documentation and Chart Metadata
README.mdto document the newextraVolumesandextraVolumeMountsoptions for each component, ensuring users are aware of the new configuration capabilities. [1] [2] [3] [4]Chart.yamland the version badge inREADME.mdto reflect these changes. [1] [2]