Skip to content

Closes #347: Include ObjectChange ID in log when applying/undoing changes #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2025
Merged

Closes #347: Include ObjectChange ID in log when applying/undoing changes #351

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions netbox_branching/models/changes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def apply(self, branch, using=DEFAULT_DB_ALIAS, logger=None):
"""
logger = logger or logging.getLogger('netbox_branching.models.ObjectChange.apply')
model = self.changed_object_type.model_class()
logger.info(f'Applying change {self} using {using}')
logger.info(f'Applying change {self.pk} using {using} ({self})')

# Run data migrators
self.migrate(branch)
Expand Down Expand Up @@ -79,7 +79,7 @@ def undo(self, branch, using=DEFAULT_DB_ALIAS, logger=None):
"""
logger = logger or logging.getLogger('netbox_branching.models.ObjectChange.undo')
model = self.changed_object_type.model_class()
logger.info(f'Undoing change {self} using {using}')
logger.info(f'Undoing change {self.pk} using {using} ({self})')

# Run data migrators
self.migrate(branch, revert=True)
Expand Down