fix(bulk-import): lookup custom object via slug #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
custom objects are indexed via the view's url, which is derived from the custom object's slug. the existing bulk import form looked up the custom object by name though, rather than slug. this commit fixes that bad lookup field. the bulk import and bulk delete forms already do this. additionally, we add a slug uniqueness constraint on the custom object type for additional safeguarding
|
Thanks @anshulkamath . Sanity check, does this need a migration? |
|
@bctiemann great catch. I've updated the PR with the migration |
bctiemann
requested changes
Oct 20, 2025
netbox_custom_objects/models.py
Outdated
| "A Custom Object Type with this name already exists." | ||
| ), | ||
| ), | ||
| models.UniqueConstraint( |
There was a problem hiding this comment.
Is this necessary if we already have unique=True on the slug field? I believe it's implicit unless you really want to override the error message.
There was a problem hiding this comment.
I missed that one. Overriding is not necessary then.
| @@ -0,0 +1,20 @@ | |||
| # Generated by Django 5.2.7 on 2025-10-20 13:24 | |||
There was a problem hiding this comment.
If this UniqueConstraint is necessary (I don't think it is), could you please rename this migration to something a bit more informative/less unwieldy (following the usual pattern in NetBox core migrations)?
There was a problem hiding this comment.
Removed the unique constraint
bctiemann
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #251
custom objects are indexed via the view's url, which is derived from the custom object's slug. the existing bulk import form looked up the custom object by name though, rather than slug. this commit fixes that bad lookup field. the bulk import and bulk delete forms already do this.
additionally, we add a slug uniqueness constraint on the custom object type for additional safeguarding