feat: add standard Docker support for MCP server #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add single Dockerfile for containerized deployment of NetBox MCP server. Focused on mainline MCP use cases (Claude Desktop, Claude Code, MCP-aware clients). Docker Image Details: - Multi-stage Alpine-based build (140MB final size) - Non-root user (appuser:1000) for security - Build cache optimization via mount directives - EXPOSE 8000 directive for documentation - Follows Docker conventions (trailing newlines, .dockerignore) Configuration: - All settings via environment variables - Supports HTTP transport (required for Docker) - Full configuration system integration - Examples in README for common scenarios OpenWebUI Integration: - Documented approach using standalone mcpo wrapper - Keeps repo focused on core MCP implementation - Users can extend with protocol translators as needed Architectural Decision: - Dockerfile.mcpo intentionally not included - MCPO is a generic MCP→OpenAPI translator - Not NetBox-specific, better as separate tool - Documentation provided for users who need it Testing: - Image builds successfully (140MB) - EXPOSE 8000 verified - Non-root user confirmed - HTTP transport tested Based on excellent work in PR #26 by @mhajder - Adopted multi-stage Alpine build pattern - Security practices (non-root, minimal deps) - Build optimization techniques Co-authored-by: Mateusz Hajder <6783135+mhajder@users.noreply.github.com> Co-authored-by: Anton Bubna-Litic <abubnalitic@netboxlabs.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds Docker support for containerized deployment of the NetBox MCP Server with a focus on standard MCP use cases. It provides a production-ready, security-hardened Docker image built using multi-stage Alpine builds.
Key Changes:
- Multi-stage Dockerfile optimized for size (140MB) and security with non-root user
- Comprehensive Docker usage documentation with examples for various scenarios
- Docker ignore file to optimize build context
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Dockerfile | Multi-stage Alpine-based build with security best practices (non-root user, minimal image) |
| .dockerignore | Excludes unnecessary files from Docker build context for faster builds |
| README.md | Adds Docker usage section with deployment examples and configuration guidance |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ltucker
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Docker support for containerized deployment of the NetBox MCP Server, focused on mainline MCP use cases.
Key Features:
Architectural Decision:
This PR includes only the standard Dockerfile. MCPO integration for OpenWebUI is not bundled, keeping the repo focused on NetBox MCP implementation rather than protocol translation layers.
Attribution
Based on the excellent multi-stage Alpine Dockerfile from PR #26 by @mhajder. Thank you for the quality work and contribution!
Related:
Supersedes #26 with focused scope on standard MCP use cases.
Closes #26