-
Notifications
You must be signed in to change notification settings - Fork 12
feat: remove groups #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: remove groups #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Go test coverage
Total coverage: 62.1% |
leoparente
approved these changes
Oct 10, 2025
|
🎉 This PR is included in version 2.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for handling group removal events in the MQTT fleet connection and messaging system. It refactors how topic actions (subscribe, publish, unsubscribe) are passed around, and adds logic to properly unsubscribe from topics and clean up associated policies when a group is removed.
Key changes include:
Support for Group Removal and Policy Cleanup:
handleAgentGroupRemovalinMessagingto process group removal events. This handler unsubscribes from the relevant MQTT topic and removes or updates policies that are no longer associated with any group or dataset.GroupRemovedRPCFuncmessage type in the dispatcher, invoking the new handler when such a message is received.Refactoring of Topic Actions:
TopicActionsstruct to encapsulate subscribe, publish, and unsubscribe functions, simplifying how these actions are passed between components. [1] [2]TopicActionsstruct, including adding anunsubscribeFromTopicmethod to handle topic unsubscriptions. [1] [2]Message Payload Changes:
ChannelIDfield from theGroupRemovedRPCPayloadstruct, streamlining the payload for group removal events.Dependency Update:
backendpackage infrom_rpc.goto support backend-specific operations in policy cleanup.