fix: sanitize config before sending #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Go test coverage
Total coverage: 57.5% |
jajeffries
requested review from
MicahParks,
leoparente and
mfiedorowicz
as code owners
leoparente
approved these changes
Oct 23, 2025
|
🎉 This PR is included in version 2.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new method to safely serialize the agent configuration for fleet management, ensuring that sensitive information such as the client secret is masked before being transmitted or logged. The changes also include comprehensive unit tests to verify the masking behavior and ensure the original configuration object remains unmodified.
Sensitive data handling improvements:
configToSafeStringmethod tofleetConfigManager, which replaces theClientSecretfield with"******"before serializing the configuration to YAML, preventing accidental exposure of secrets.Startmethod to useconfigToSafeStringinstead of direct YAML marshaling, improving security when connecting to the fleet backend.Testing enhancements:
TestFleetConfigManager_configToSafeStringunit test to verify that the client secret is properly masked in the YAML output and that the original secret value is not present.TestFleetConfigManager_configToSafeString_DoesNotModifyOriginalunit test to ensure that the original configuration object is not altered by the masking process.