Skip to content

fix: resolve envvar for git url #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2025
Merged

fix: resolve envvar for git url #215

merged 1 commit into from
Oct 30, 2025

Conversation

@leoparente
Copy link
Contributor

@leoparente leoparente commented Oct 30, 2025

This pull request introduces an improvement to the gitConfigManager startup logic by ensuring that environment variables in the Git configuration URL are properly resolved before use.

Configuration handling:

  • agent/configmgr/git.go: Added a call to config.ResolveEnv to resolve environment variables in gc.config.URL and handle any errors that may occur during this process.

@leoparente leoparente self-assigned this Oct 30, 2025
@github-actions
Copy link

github-actions bot commented Oct 30, 2025

Go test coverage

STATUS ELAPSED PACKAGE COVER PASS FAIL SKIP
🟢 PASS 0.01s github.com/netboxlabs/orb-agent/agent 0.0% 0 0 0
🟢 PASS 1.11s github.com/netboxlabs/orb-agent/agent/backend 33.3% 30 0 0
🟢 PASS 4.03s github.com/netboxlabs/orb-agent/agent/backend/devicediscovery 67.1% 2 0 0
🟢 PASS 0.00s github.com/netboxlabs/orb-agent/agent/backend/mocks 0.0% 0 0 0
🟢 PASS 4.03s github.com/netboxlabs/orb-agent/agent/backend/networkdiscovery 59.0% 2 0 0
🟢 PASS 4.02s github.com/netboxlabs/orb-agent/agent/backend/opentelemetryinfinity 46.3% 2 0 0
🟢 PASS 4.03s github.com/netboxlabs/orb-agent/agent/backend/pktvisor 67.0% 2 0 0
🟢 PASS 4.03s github.com/netboxlabs/orb-agent/agent/backend/snmpdiscovery 58.5% 2 0 0
🟢 PASS 5.03s github.com/netboxlabs/orb-agent/agent/backend/worker 68.1% 3 0 0
🟢 PASS 1.01s github.com/netboxlabs/orb-agent/agent/config 100.0% 6 0 0
🟢 PASS 31.16s github.com/netboxlabs/orb-agent/agent/configmgr 51.6% 18 0 0
🟢 PASS 4.54s github.com/netboxlabs/orb-agent/agent/configmgr/fleet 71.3% 126 0 0
🟢 PASS 1.01s github.com/netboxlabs/orb-agent/agent/policies 100.0% 15 0 0
🟢 PASS 1.02s github.com/netboxlabs/orb-agent/agent/policymgr 71.2% 10 0 0
🟢 PASS 30.62s github.com/netboxlabs/orb-agent/agent/secretsmgr 48.9% 54 0 0
🟢 PASS 1.02s github.com/netboxlabs/orb-agent/agent/telemetry 81.7% 19 0 0
🟢 PASS 1.01s github.com/netboxlabs/orb-agent/agent/version 100.0% 1 0 0

Total coverage: 57.5%

@leoparente leoparente merged commit fc1e548 into develop Oct 30, 2025
5 of 6 checks passed
@leoparente leoparente deleted the fix/resolve-env-git-url branch October 30, 2025 19:10
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

🎉 This PR is included in version 2.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

🎉 This PR is included in version 2.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MicahParks MicahParks MicahParks approved these changes

@rboucher-me rboucher-me Awaiting requested review from rboucher-me

@jajeffries jajeffries Awaiting requested review from jajeffries jajeffries is a code owner

@mfiedorowicz mfiedorowicz Awaiting requested review from mfiedorowicz mfiedorowicz is a code owner

Assignees

@leoparente leoparente

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leoparente @MicahParks