Skip to content

Commit eb3bcb2

Browse files
committed
add result[:mentioned_usernames] for MentionFilter
1 parent 98fc8dd commit eb3bcb2

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

lib/html/pipeline/@mention_filter.rb

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,8 @@ def self.mentioned_logins_in(text)
6060
IGNORE_PARENTS = %w(pre code a).to_set
6161

6262
def call
63+
result[:mentioned_usernames] ||= []
64+
6365
doc.search('text()').each do |node|
6466
content = node.to_html
6567
next if !content.include?('@')
@@ -108,6 +110,7 @@ def link_to_mention_info(text, info_url=nil)
108110
end
109111

110112
def link_to_mentioned_user(login)
113+
result[:mentioned_usernames] |= [login]
111114
url = File.join(base_url, login)
112115
"<a href='#{url}' class='user-mention'>" +
113116
"@#{login}" +

test/html/pipeline/mention_filter_test.rb

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -76,9 +76,7 @@ def test_links_to_more_info_when_info_url_given
7676
def mentioned_usernames
7777
result = {}
7878
MarkdownPipeline.call(@body, {}, result)
79-
html = result[:output].to_html
80-
users = html.scan(/user-mention">@(.+?)</)
81-
users ? users.flatten.uniq : []
79+
result[:mentioned_usernames]
8280
end
8381

8482
def test_matches_usernames_in_body

0 commit comments

Comments
 (0)