Skip to content

remove checkbox overlay #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacekkolasa merged 2 commits into from
Nov 16, 2022
Merged

remove checkbox overlay #404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82428d3
remove checkbox overlay
jacekkolasa Nov 15, 2022
6e079a5
v2.5.2
jacekkolasa Nov 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@netdata/netdata-ui",
"version": "2.5.1",
"version": "2.5.2",
"description": "netdata UI kit",
"main": "./lib/index.js",
"files": [
Expand Down
21 changes: 9 additions & 12 deletions src/components/checkbox/checkbox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,20 +3,12 @@ import { Text } from "src/components/typography"
import useCheckBoxStyles from "./use-styles-checkbox"
import useCheckbox from "./use-checkbox"

import {
CheckboxContainer,
HiddenCheckboxInput,
StyledCheckbox,
StyledLabel,
LabelText,
StyledIcon,
AccessibleArea,
} from "./styled"
import { CheckboxContainer, HiddenCheckboxInput, LabelText, StyledCheckbox, StyledIcon, StyledLabel } from "./styled"

export const Checkbox = forwardRef((
{
checked,
'data-testid': testId,
"data-testid": testId,
disabled,
className,
labelPosition,
Expand All @@ -39,8 +31,13 @@ export const Checkbox = forwardRef((
})

return (
<StyledLabel data-testid={testId} disabled={disabled} className={className} margin={margin} alignSelf={alignSelf}>
<AccessibleArea />
<StyledLabel
data-testid={testId}
disabled={disabled}
className={className}
margin={margin}
alignSelf={alignSelf}
>
{label && labelPosition === "left" && (
<LabelText as={Label} left>
{label}
Expand Down
11 changes: 1 addition & 10 deletions src/components/checkbox/styled.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
import styled from "styled-components"
import { Icon } from "src/components/icon"
import { getValidatedControlColor, getColor, getSizeUnit } from "src/theme/utils"
import { getSizeUnit, getValidatedControlColor } from "src/theme/utils"
import margin from "src/mixins/margin"
import alignSelf from "src/mixins/alignSelf"
import { controlFocused } from "src/mixins"

import Flex from "src/components/templates/flex"

Expand Down Expand Up @@ -60,11 +59,3 @@ export const LabelText = styled.span`
${({ right, ...props }) =>
right ? `margin-left: ${getSizeUnit(props)}px;` : `margin-right: ${getSizeUnit(props)}px;`}
`

export const AccessibleArea = styled.div`
position: absolute;
top: -5px;
left: -5px;
height: 30px;
width: calc(100% + 10px);
`