Loading state on confirmation dialog #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapantzak
force-pushed
the
confirmation-dialog-button-loading
branch
from
c52b5de to
c5e4b20
Compare
burbuli8ra
approved these changes
Mar 24, 2023
kapantzak
force-pushed
the
confirmation-dialog-button-loading
branch
from
292d651 to
2c71661
Compare
kapantzak
added a commit
that referenced
this pull request
Mar 27, 2023
This reverts commit abfc11d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to configure the appearance of a loader when the confirm button is clicked on the confirmation dialog.
The loader can be toggled from inside the
handleConfirmfunction, since it (thehandleConfirm) gets atoggleLoadingfunction as it's second argument.