Skip to content

Remove Warnings (ebpf)#18484

Merged
thiagoftsm merged 8 commits intonetdata:masterfrom
thiagoftsm:remove_warnings
Sep 5, 2024
Merged

Remove Warnings (ebpf)#18484
thiagoftsm merged 8 commits intonetdata:masterfrom
thiagoftsm:remove_warnings

Conversation

@thiagoftsm
Copy link
Copy Markdown
Contributor

Summary

This PR removes warnings when eBPF plugin is compiled.

Test Plan
  1. Compile this Branch with the following CFLAGS and verify there is no warnings in plugin files:
CFLAGS="-O1 -ggdb -Wall -Wextra -fno-omit-frame-pointer -Wformat-signedness -fstack-protector-all -Wformat-truncation=2 -Wunused-result
Additional Information
For users: How does this change affect me?

@github-actions github-actions bot added area/collectors Everything related to data collection collectors/ebpf labels Sep 5, 2024
@thiagoftsm thiagoftsm requested a review from stelfrag September 5, 2024 04:08
@stelfrag
Copy link
Copy Markdown
Collaborator

stelfrag commented Sep 5, 2024

One warning

ebpf_cachestat.c:717:72: warning: unused parameter ‘max_period’ [-Wunused-parameter]

@thiagoftsm
Copy link
Copy Markdown
Contributor Author

One warning

Last commit address this, thank you!

@thiagoftsm thiagoftsm merged commit 6611f94 into netdata:master Sep 5, 2024
@thiagoftsm thiagoftsm deleted the remove_warnings branch September 5, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/collectors Everything related to data collection collectors/ebpf

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants