Merged
Conversation
…on the process tree
…ific functions; not yet working on windows
Ancairon
reviewed
Sep 30, 2024
Co-authored-by: Fotis Voutsas <fotis@netdata.cloud>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is almost a total rewrite of the code of apps.plugin:
struct pid_statpointers. The previous logic was assuming that the number of possible PIDs is small. However windows supports pids up to 2 billion, so the index is now a hashtable.pid_stat.STRING).process_treegrouping).treegrouping, which uses the top-level process of the process tree, to aggregate all the processes to. This eliminates the need to maintainapp_groups.conf.systemdand pid 1 are already considered process orchestratorsNANOSECONDCORES, so in 1 billion increments per core.On Windows,
apps_groups.confis not supported. The only possible grouping istree.Tests needed:
To verify CPU, I have added a program called
busy_threads, which creates N busy threads. The CPU utilization shown at theprocessesfunction and the charts, should match the number of busy threads spawn.