Remove the overview section from cloud notif. integrations#18754
Merged
ilyam8 merged 4 commits intonetdata:masterfrom Oct 14, 2024
Merged
Remove the overview section from cloud notif. integrations#18754ilyam8 merged 4 commits intonetdata:masterfrom
ilyam8 merged 4 commits intonetdata:masterfrom
Conversation
…ouple the notification integrations (agent-cloud)
ilyam8
previously approved these changes
Oct 14, 2024
ilyam8
approved these changes
Oct 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I removed the overview section completely, I tried keeping it, but then figured we don't need that sentence at all, it is just unnecessary.
I de-coupled the Agent and Cloud notification integrations, so that we can only touch the Cloud ones with this change.
only yikes part from my testing is that there is one tab, it reads "setup" and heading is "setup".
What I think is that maybe I can remove the "Setup" heading from the cloud notification integrations rendering inside the js file and render it only for docs. What do you think @ilyam8