Skip to content

Add defines for cleanup statements#20570

Merged
stelfrag merged 4 commits intonetdata:masterfrom
stelfrag:cleanup_statements
Jun 26, 2025
Merged

Add defines for cleanup statements#20570
stelfrag merged 4 commits intonetdata:masterfrom
stelfrag:cleanup_statements

Conversation

@stelfrag
Copy link
Collaborator

Summary
  • Add defines for some cleanup statements

@stelfrag stelfrag marked this pull request as ready for review June 24, 2025 20:04
@thiagoftsm
Copy link
Contributor

I didn’t find any issues, but I did notice the following warning:

/home/thiago/Netdata/tests_netdata/src/database/sqlite/sqlite_metadata.c: In function 'store_hosts_metadata':
/home/thiago/Netdata/tests_netdata/src/database/sqlite/sqlite_metadata.c:2404:9: warning: 'started_ut' may be used uninitialized [-Wmaybe-uninitialized]
 2404 |         COMPUTE_DURATION(report_duration, "us", started_ut, now_monotonic_usec());
      |         ^
/home/thiago/Netdata/tests_netdata/src/database/sqlite/sqlite_metadata.c:2369:12: note: 'started_ut' was declared here
 2369 |     usec_t started_ut;
      |            ^

Would you prefer to address this warning in this PR or in a separate one?

@stelfrag
Copy link
Collaborator Author

Would you prefer to address this warning in this PR or in a separate one?

I adjusted the code (although it was not a problem)

Copy link
Contributor

@thiagoftsm thiagoftsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the last commit, all warnings have been resolved and the PR is working as expected. LGTM!

@stelfrag stelfrag merged commit 3f6a59d into netdata:master Jun 26, 2025
108 checks passed
@stelfrag stelfrag deleted the cleanup_statements branch July 2, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants