Merged
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 4 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="src/collectors/windows.plugin/perflib-mssql.c">
<violation number="1" location="src/collectors/windows.plugin/perflib-mssql.c:423">
Perflib user-connection collection is now gated on `collect_user_connections`, so disabling the SQL probe also disables the perflib fallback and the metric never updates.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
stelfrag
reviewed
Nov 25, 2025
stelfrag
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Despite collecting data from Perflib, this PR adds data collection from SQL because it appears to be more reliable when compared to other MSSQL tools.
Test Plan
Additional Information
For users: How does this change affect me?
Summary by cubic
Add SQL-based collection for MSSQL user connections to improve reliability when Perflib is incomplete. Also adds a config flag to control this collection and updates charts to plot the metric.
Written for commit df56ce5. Summary will update automatically on new commits.