Skip to content

Use only major version for repo URL in RHEL 9/10.#21596

Merged
Ferroin merged 1 commit intonetdata:masterfrom
Ferroin:rhel-repoconfig-releasever
Jan 21, 2026
Merged

Use only major version for repo URL in RHEL 9/10.#21596
Ferroin merged 1 commit intonetdata:masterfrom
Ferroin:rhel-repoconfig-releasever

Conversation

@Ferroin
Copy link
Member

@Ferroin Ferroin commented Jan 20, 2026

Summary

At least some installs of these versions will set the full release version in the DNF variables instead of only setting the major version, but DNF on these platforms supports just templating in the major version, so do that instead.

Test Plan

n/a

Additional Information

Fixes: #21576

At least some installs of these versions will set the full release
version in the DNF variables instead of only setting the major version,
but DNF on these platforms supports just templating in the major
version, so do that instead.
@github-actions github-actions bot added the area/packaging Packaging and operating systems support label Jan 20, 2026
@Ferroin Ferroin marked this pull request as ready for review January 20, 2026 14:22
@Ferroin Ferroin requested review from a team and vkalintiris as code owners January 20, 2026 14:22
@Ferroin Ferroin requested a review from a team January 20, 2026 14:22
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an issue where some RHEL 9/10 installations set the full release version instead of just the major version in DNF variables. The solution uses $releasever_major for repository URLs on RHEL 9+ platforms, and explicitly sets version numbers for Amazon Linux to avoid relying on defaults.

Changes:

  • Updated repository configuration to use $releasever_major for RHEL 9+ instead of $releasever
  • Explicitly set version number for Amazon Linux 2 instead of relying on defaults
  • Bumped package version from 5-2 to 5-3 in both RPM and DEB changelogs

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
packaging/repoconfig/rpm.changelog Added changelog entry for version 5-3 documenting the $releasever_major change
packaging/repoconfig/deb.changelog Added version bump entry to keep DEB packages in sync with RPM packages
packaging/repoconfig/CMakeLists.txt Updated PACKAGE_RELEASE to 3, explicitly set DIST_VERSION for Amazon Linux 2, and added $releasever_major for RHEL 9+

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Ferroin Ferroin merged commit d224466 into netdata:master Jan 21, 2026
175 checks passed
@Ferroin Ferroin deleted the rhel-repoconfig-releasever branch January 21, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/packaging Packaging and operating systems support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: kickstart.sh fails on RHEL 9.6 - repository URL uses minor version (9.6) instead of major version (9)

3 participants