Path improv #909
Merged
Path improv #909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dinesh Dutt <dd.ps4u@gmail.com>
claudious96
approved these changes
Jul 17, 2023
claudious96
reviewed
Jul 17, 2023
suzieq/engines/pandas/path.py
Outdated
| if ':' in source: | ||
| self._src_df = ( | ||
| self._if_df.query( | ||
| f'@self._in_subnet-series("{source}", ip6AddressList)' |
Collaborator
There was a problem hiding this comment.
Suggested change
| f'@self._in_subnet-series("{source}", ip6AddressList)' | |
| f'@self._in_subnet_series("{source}", ip6AddressList)' |
If the given source is not found either via the address of a polled device or via the arpnd tables, instead of giving up, see if you can find an SVI and start trace from that SVI. Also hanldes MLAG pairs as the source of the SVI. If there are more than 2 possible sources in this situation, we don't proceed. This can be the case when for example, we have a distributed symmetric EVPN where the same default gateway IP is present on all hosts that support that VNI. Signed-off-by: Dinesh Dutt <dd.ps4u@gmail.com>
Signed-off-by: Dinesh Dutt <dd.ps4u@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle path when the source is not in ARP or as interface on a polled node, by seeking the SVI associated with that source.
Type of change
Enhancement
New Behavior
Without this patch, if you provide a source IP address that is not in the arpnd table or as the address of an interface on a polled device, the command fails with "invalid src:...". With this patch, we find the SVI associated with the IP and start tracing from that node's SVI.
If we cannot find an SVI, we flag the error: "unable to find a source node to start for"
Discussion: Benefits and Drawbacks
This is a useful feature for many people using path because the source's ARP entry may have timed out, people are testing a hypothetical source etc.
Changes to the Documentation
None.
Proposed Release Note Entry
ENHANCEMENT: path now supports specifying a source IP that may not be in the ARPND table. We determine the SVI node(s) associated with the IP and start the trace from there. Furthermore, the error message associated with a source IP whose source node we cannot locate is made more user-friendly now.
Double Check
developbranch.developbranch.--signoffapplied