Missing stack traces

[DavidWells]

Describe the bug

Error messages being swallowed

Related issue netlify-labs/netlify-plugin-next#2

"Error: Error" is being shown vs actual error.

To reproduce, clone down netlify-labs/netlify-plugin-next@52b23f9 and run netlify build locally

Configuration

System:
    OS: macOS High Sierra 10.13.6
    CPU: (8) x64 Intel(R) Core(TM) i7-7920HQ CPU @ 3.10GHz
    Memory: 55.08 MB / 16.00 GB
    Shell: 5.3 - /bin/zsh
  Binaries:
    Node: 12.7.0 - ~/.nvm/versions/node/v12.7.0/bin/node
    Yarn: 1.17.3 - ~/.nvm/versions/node/v12.7.0/bin/yarn
    npm: 6.10.0 - ~/.nvm/versions/node/v12.7.0/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  npmGlobalPackages:
    netlify-cli: 2.58.0

[ehmicky]

Hi @DavidWells,

I cloned the plugin's repository, used it in a project then ran netlify build. The error included a stack trace:

┌─────────────────────────────┐
│        Netlify Build        │
└─────────────────────────────┘

❯ Version
  @netlify/build 3.0.1

❯ Flags
  mode: cli

❯ Current directory
  /home/ether/code/cv-website

❯ Config file
  /home/ether/code/cv-website/netlify.toml

❯ Context
  production

❯ Installing plugins
   - @netlify/plugin-sitemap

❯ Loading plugins
   - @netlify/plugin-sitemap@0.3.4 from netlify.toml
   - ../../Desktop/repos/netlify-plugin-next/next-plugin@0.0.4 from netlify.toml

┌────────────────────────────────────────────────────────────────────────────────┐
│ 1. onPreBuild command from ../../Desktop/repos/netlify-plugin-next/next-plugin │
└────────────────────────────────────────────────────────────────────────────────┘

No Next cache found. Building fresh.

(../../Desktop/repos/netlify-plugin-next/next-plugin onPreBuild completed in 99ms)

┌────────────────────────────────────┐
│ 2. build.command from netlify.toml │
└────────────────────────────────────┘

$ gulp build
[12:59:12] Using gulpfile ~/code/cv-website/gulpfile.js
[12:59:12] Starting 'build'...
[12:59:12] Starting 'clean'...
(node:9852) [DEP0097] DeprecationWarning: Using a domain property in MakeCallback is deprecated. Use the async_context variant of MakeCallback or the AsyncResource class instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
[12:59:12] Finished 'clean' after 9.45 ms
[12:59:12] Starting 'move'...
[12:59:12] Finished 'move' after 50 ms
[12:59:12] Starting 'uglify'...
[12:59:12] Finished 'uglify' after 38 ms
[12:59:12] Finished 'build' after 99 ms

(build.command completed in 552ms)

┌─────────────────────────────────────────────────────────────────────────────┐
│ 3. onBuild command from ../../Desktop/repos/netlify-plugin-next/next-plugin │
└─────────────────────────────────────────────────────────────────────────────┘

/home/ether/Desktop/repos/netlify-plugin-next/node_modules/jsonfile/index.js:56
      throw err
      ^

Error: .next/serverless/pages-manifest.json: ENOENT: no such file or directory, open '.next/serverless/pages-manifest.json'
    at Object.openSync (fs.js:465:3)
    at Object.readFileSync (fs.js:368:35)
    at readFileSync (/home/ether/Desktop/repos/netlify-plugin-next/node_modules/jsonfile/index.js:50:22)
    at getAllPages (/home/ether/Desktop/repos/netlify-plugin-next/node_modules/next-on-netlify/lib/allNextJsPages.js:10:27)
    at Object.<anonymous> (/home/ether/Desktop/repos/netlify-plugin-next/node_modules/next-on-netlify/lib/allNextJsPages.js:122:24)
    at Module._compile (internal/modules/cjs/loader.js:1201:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1221:10)
    at Module.load (internal/modules/cjs/loader.js:1050:32)
    at Function.Module._load (internal/modules/cjs/loader.js:938:14)
    at Module.require (internal/modules/cjs/loader.js:1090:19) {
  errno: -2,
  syscall: 'open',
  code: 'ENOENT',
  path: '.next/serverless/pages-manifest.json'
}

┌─────────────────────────────────────────────────────────────────────────────┐
│ Plugin "../../Desktop/repos/netlify-plugin-next/next-plugin" internal error │
└─────────────────────────────────────────────────────────────────────────────┘

  Error message
  Error: Error: Command failed with exit code 1: next-on-netlify

  Plugin details
  Package:        ../../Desktop/repos/netlify-plugin-next/next-plugin
  Version:        0.0.4
  Repository:     git+https://github.com/netlify-labs/netlify-plugin-next.git
  npm link:       https://www.npmjs.com/package/@netlify/plugin-next
  Report issues:  https://github.com/netlify-labs/netlify-plugin-next/issues

  Error location
  In "onBuild" event in "../../Desktop/repos/netlify-plugin-next/next-plugin" from netlify.toml
      at onBuild (/home/ether/Desktop/repos/netlify-plugin-next/next-plugin/index.js:44:13)
      at processTicksAndRejections (internal/process/task_queues.js:93:5)
      at async Object.run (/home/ether/netlify/cli/node_modules/@netlify/build/src/plugins/child/run.js:13:3)
      at async handleEvent (/home/ether/netlify/cli/node_modules/@netlify/build/src/plugins/child/main.js:34:38)
      at async process.<anonymous> (/home/ether/netlify/cli/node_modules/@netlify/build/src/plugins/ipc.js:102:9)

  Resolved config
  build:
    command: gulp build
    commandOrigin: config
    environment:
      - NETLIFY_BUILD_DEBUG
      - NODE_VERSION
      - AWS_LAMBDA_JS_RUNTIME
    functions: /home/ether/code/cv-website/functions
    processing:
      css:
        bundle: true
        minify: true
      html:
        pretty_urls: true
      images:
        compress: true
      js:
        bundle: true
        minify: true
    publish: /home/ether/code/cv-website/build
  plugins:
    - inputs: {}
      origin: config
      package: '@netlify/plugin-sitemap'
    - inputs: {}
      origin: config
      package: ../../Desktop/repos/netlify-plugin-next/next-plugin

Would it be possible to create a demo repository?
Also, please feel free to post the full build logs (also in future bug reports), as they contain additional information. Thanks!

[DavidWells]

It looks like you are getting a different error that is throwing the stack trace.

The line: Copy node_modules for next.js function is missing from your logs there. It looks like you are hitting a different error. Related to this, does onBuild run before the command in toml?

[DavidWells]

Full logs of the error I am seeing:

netlify build

┌─────────────────────────────┐
│        Netlify Build        │
└─────────────────────────────┘

❯ Version
  @netlify/build 2.0.27

❯ Flags
  mode: cli

❯ Current directory
  /Users/davidwells/Netlify/projects/next-research/netlify-plugin-next

❯ Config file
  /Users/davidwells/Netlify/projects/next-research/netlify-plugin-next/netlify.toml

❯ Context
  production

❯ Loading plugins
   - @netlify/plugin-sitemap@0.3.4 from netlify.toml and package.json
   - @netlify/plugin-next@0.0.3 from netlify.toml and package.json

┌─────────────────────────────────────────────────┐
│ 1. onPreBuild command from @netlify/plugin-next │
└─────────────────────────────────────────────────┘

constants {
  CONFIG_PATH: 'netlify.toml',
  PUBLISH_DIR: 'out_publish',
  FUNCTIONS_SRC: 'out_functions',
  FUNCTIONS_DIST: '.netlify/functions/',
  CACHE_DIR: '.netlify/cache',
  IS_LOCAL: true,
  NETLIFY_BUILD_VERSION: '2.0.27',
  SITE_ID: '15b94630-19f0-xxxx-99f5-68d6ba7132a6'
}
Found a Next cache. We’re about to go FAST. ⚡️

(@netlify/plugin-next onPreBuild completed in 1.2s)

┌────────────────────────────────────┐
│ 2. build.command from netlify.toml │
└────────────────────────────────────┘

$ npm run build

> next-netlify-starter@0.1.0 build /Users/davidwells/Netlify/projects/next-research/netlify-plugin-next
> next build

Creating an optimized production build

Compiled with warnings.

./node_modules/next/dist/next-server/server/load-components.js
Critical dependency: the request of a dependency is an expression

./node_modules/next/dist/next-server/server/load-components.js
Critical dependency: the request of a dependency is an expression

./node_modules/next/dist/next-server/server/load-components.js
Critical dependency: the request of a dependency is an expression

./node_modules/next/dist/next-server/server/load-components.js
Critical dependency: the request of a dependency is an expression

./node_modules/next/dist/next-server/server/require.js
Critical dependency: the request of a dependency is an expression

./node_modules/next/dist/next-server/server/require.js
Critical dependency: the request of a dependency is an expression

Automatically optimizing pages

Page                            Size     First Load JS
┌ ○ /                           1.1 kB         65.9 kB
├ ○ /404                        2.6 kB         61.2 kB
├ λ /api/hello
├ ● /dynamic/[dynamic]          1.75 kB        66.5 kB
└ ● /other/[other]              1.74 kB        66.5 kB
+ First Load JS shared by all   58.6 kB
  ├ static/pages/_app.js        979 B
  ├ chunks/commons.39f9bf.js    10.7 kB
  ├ chunks/framework.e84fa6.js  40 kB
  ├ runtime/main.ade55b.js      6.27 kB
  └ runtime/webpack.c21266.js   746 B

λ  (Lambda)  server-side renders at runtime (uses getInitialProps or getServerSideProps)
○  (Static)  automatically rendered as static HTML (uses no initial props)
●  (SSG)     automatically generated as static HTML + JSON (uses getStaticProps)


(build.command completed in 9.8s)

┌──────────────────────────────────────────────┐
│ 3. onBuild command from @netlify/plugin-next │
└──────────────────────────────────────────────┘

🚀 Next on Netlify 🚀
   Functions directory: out_publish/
   Publish directory:   out_functions/
   Make sure these are set in your netlify.toml file.
🌍️ Copying public/ folder to out_publish/
💼 Copying static NextJS assets to out_publish/
💫 Setting up SSR pages as Netlify Functions in out_functions/
   pages/api/hello.js
🔥 Setting up SSG pages
   1. Copying pre-rendered SSG pages to out_publish/
   2. Copying SSG page data to out_publish/_next/data/
   3. Setting up Netlify Functions for SSG pages with fallback: true
      pages/dynamic/[dynamic].js
      pages/other/[other].js
📝 Writing pre-rendered HTML pages to out_publish/
   pages/index.html
   pages/404.html
🔀 Setting up redirects
   /api/hello  /.netlify/functions/next_api_hello  200
   /index  /index.html  200
   /  /index.html  200
   /404  /404.html  200
   /dynamic/:dynamic  /.netlify/functions/next_dynamic_dynamic  200
   /_next/data/Mif-EFpZQTQbf50DVe0vy/dynamic/:dynamic.json  /.netlify/functions/next_dynamic_dynamic  200
   /other/:other  /.netlify/functions/next_other_other  200
   /_next/data/Mif-EFpZQTQbf50DVe0vy/other/:other.json  /.netlify/functions/next_other_other  200
✅ Success! All done!
──────────────────────────────────────────────
Copy node_modules for next.js to functions...
┌─────────────────────────────┐
│     Core internal error     │
└─────────────────────────────┘

  Error message
  Error: Error

  Error location
      at normalizeError (/Users/davidwells/.nvm/versions/node/v12.7.0/lib/node_modules/netlify-cli/node_modules/@netlify/build/src/error/parse/parse.js:75:10)
      at parseErrorInfo (/Users/davidwells/.nvm/versions/node/v12.7.0/lib/node_modules/netlify-cli/node_modules/@netlify/build/src/error/parse/parse.js:50:70)
      at parseError (/Users/davidwells/.nvm/versions/node/v12.7.0/lib/node_modules/netlify-cli/node_modules/@netlify/build/src/error/parse/parse.js:26:7)
      at serializeLogError (/Users/davidwells/.nvm/versions/node/v12.7.0/lib/node_modules/netlify-cli/node_modules/@netlify/build/src/error/parse/serialize_log.js:7:94)
      at logBuildError (/Users/davidwells/.nvm/versions/node/v12.7.0/lib/node_modules/netlify-cli/node_modules/@netlify/build/src/log/main.js:250:72)
      at build (/Users/davidwells/.nvm/versions/node/v12.7.0/lib/node_modules/netlify-cli/node_modules/@netlify/build/src/core/main.js:119:5)
      at async BuildCommand.run (/Users/davidwells/.nvm/versions/node/v12.7.0/lib/node_modules/netlify-cli/src/commands/build/index.js:16:25)
      at async BuildCommand._run (/Users/davidwells/.nvm/versions/node/v12.7.0/lib/node_modules/netlify-cli/node_modules/@oclif/command/lib/command.js:43:20)

There was some broken logic in my code but the stack trace is hidden and shown as Error: Error

[ehmicky]

Thanks @DavidWells.
onBuild runs after the build.command.

I am probably hitting a different error, because I am missing the context in which you triggered the error above.
Would it be possible to create a demo repository?

[DavidWells]

This is the demo repo netlify-labs/netlify-plugin-next@52b23f9 (at this commit)

[ehmicky]

The problem is that ncp is throwing an array of errors instead of an Error instance.

#1724 is fixing error handling to properly handle improperly thrown errors.

Once this is in production, you should see the following error instead:

This is missing a stack trace because the error thrown by ncp does not include any. But the error is being thrown here.

Note: I would recommend using make-dir (or similar library) instead of ncp since ncp has not been maintained in 6 years.