Skip to content

Conversation

@lukasholzer
Copy link
Contributor

@lukasholzer lukasholzer commented Feb 14, 2023

🎉 Thanks for submitting a pull request! 🎉

Summary

Fixes https://github.com/netlify/pillar-workflow/issues/1011

Optimisations on the WebFS where not done (to reduce http calls)
I will do this in a follow up PR as this is already a huger PR size.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@lukasholzer lukasholzer requested review from danez and jobala February 14, 2023 17:29
@github-actions
Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

danez
danez previously approved these changes Feb 16, 2023
Copy link
Contributor

@danez danez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good.

@lukasholzer lukasholzer marked this pull request as ready for review February 17, 2023 10:13
@lukasholzer lukasholzer requested a review from danez February 17, 2023 10:13

join(...segments: string[]): string {
return join(...segments)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting that path is easy to polyfill in the browser, so we do not necessarily need to add it to the FileSystem here, but I'm also not against doing that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But then you would need webpack ;) and I've built an implementation for it (added good tests as well)

@kodiakhq kodiakhq bot merged commit a1d247f into main Feb 17, 2023
@kodiakhq kodiakhq bot deleted the feat/make-build-info-browser-compatible branch February 17, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants