Skip to content

Conversation

@lemusthelroy
Copy link
Contributor

🎉 Thanks for submitting a pull request! 🎉

Summary

Integrations are changing and this also means the endpoint we use to fetch information about integrations installed on a site is also changing. This points to the new endpoint behind a feature flag.

Changes will also need to be made in buildbot to pass the accountId and a PR is due to merge in the CLI to support passing the necessary feature flags netlify/cli#6691


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@lemusthelroy lemusthelroy requested review from a team as code owners June 6, 2024 11:34
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2024

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

@Skn0tt
Copy link
Contributor

Skn0tt commented Jun 6, 2024

I believe you'll also need to add the accountId flag here:

@lemusthelroy lemusthelroy force-pushed the ljt/ct-1160-v2-new-endpoint branch from d35ab35 to 641bf33 Compare June 6, 2024 14:03
@lemusthelroy lemusthelroy enabled auto-merge (squash) June 6, 2024 15:33
@lemusthelroy lemusthelroy merged commit 07def29 into main Jun 6, 2024
@lemusthelroy lemusthelroy deleted the ljt/ct-1160-v2-new-endpoint branch June 6, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants