-
Notifications
You must be signed in to change notification settings - Fork 81
feat: add new endpoint that uses flags and accountId #5700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This pull request adds or modifies JavaScript ( |
khendrikse
reviewed
Jun 6, 2024
Contributor
|
I believe you'll also need to add the build/packages/config/src/bin/flags.ts Line 122 in e4e9787
|
d35ab35 to
641bf33
Compare
khendrikse
approved these changes
Jun 6, 2024
This was referenced Jun 6, 2024
Merged
Merged
Merged
Merged
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Integrations are changing and this also means the endpoint we use to fetch information about integrations installed on a site is also changing. This points to the new endpoint behind a feature flag.
Changes will also need to be made in buildbot to pass the
accountIdand a PR is due to merge in the CLI to support passing the necessary feature flags netlify/cli#6691For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)