fix: throw precise, actionable error when downloaded deno cli is unusable #6708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhalp
force-pushed
the
fix/actionable-dev-deno-cli-errors
branch
2 times, most recently
from
4440025 to
3865a70
Compare
serhalp
changed the title
There was a problem setting up the Edge Functions environment
``` Error: There was a problem setting up the Edge Functions environment. To try a manual installation, visit https://ntl.fyi/install-deno. ``` This happens _a lot_: https://github.com/netlify/cli/issues?q=is%3Aissue%20%22There%20was%20a%20problem%20setting%20up%20the%20Edge%20Functions%20environment%22. It means we failed to download, install, or execute a local deno binary, or we're trying to use one that doesn't behave as expected or match the expected version range. This error message is imprecise and not very actionable. This commit bubbles the previously swallowed error details, adds more info, and adds a recommended step that [has been found to unblock users](netlify/cli#7700 (comment)) and which I've personally used to unblock myself.
serhalp
force-pushed
the
fix/actionable-dev-deno-cli-errors
branch
from
3865a70 to
3f7574a
Compare
serhalp
commented
Oct 17, 2025
| Downloaded to: ${binaryPath} | ||
| Platform: ${process.platform}/${process.arch} | ||
| This may be caused by permissions, antivirus software, or platform incompatibility. |
Member
Author
There was a problem hiding this comment.
this line could be better 🤔
serhalp
commented
Oct 17, 2025
Comment on lines
+97
to
+98
| Try clearing the Deno cache directory and retrying: | ||
| ${this.cacheDirectory} |
Member
Author
There was a problem hiding this comment.
I decided not to bother dynamically producing a platform-specific command here. I think users can figure out how to delete a directory.
serhalp
commented
Oct 17, 2025
| if (!version) { | ||
| this.logger.system(`getBinaryVersion no version found. binaryPath ${binaryPath}`) | ||
| return | ||
| return { error: new Error('Could not parse Deno version from output') } |
Member
Author
There was a problem hiding this comment.
should we include the full stdout here...?
JakeChampion
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This happens a lot: https://github.com/netlify/cli/issues?q=is%3Aissue%20%22There%20was%20a%20problem%20setting%20up%20the%20Edge%20Functions%20environment%22. It confuses and blocks our users and leads to frequent bug reports that are difficult for us to troubleshoot.
It means we failed to download, install, or execute a local deno binary, or we're trying to use one that doesn't behave as expected or match the expected version range.
This error message is imprecise and not very actionable.
This PR bubbles the previously swallowed error details, adds more info, and adds a recommended step that has been found to unblock users and which I've personally used to unblock myself.