fix: make secret scanning omitvalue case insensitive #6719
                
     Merged
            
            
          
      
        
          +40
        
        
          −1
        
        
          
        
      
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
🎉 Thanks for submitting a pull request! 🎉
Summary
I've been trying to reproduce a problem where someone properly configured the
SECRETS_SCAN_SMART_DETECTION_OMIT_VALUESenv var, yet the value was still seen as a secret. I have not been able to reproduce it but I did notice that in our check we did not make things case-insensitive.The reason I think this might be necessary is because things like webpack could possibly change the casing of values.
Right now this is the only solution I could think of, apart from adding an additional check if we find a secret, to double check if it is in the omit env var, before we decide to fail the build. I'd rather try this first.
For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)