Skip to content

Conversation

@khendrikse
Copy link
Contributor

🎉 Thanks for submitting a pull request! 🎉

Summary

I've been trying to reproduce a problem where someone properly configured the SECRETS_SCAN_SMART_DETECTION_OMIT_VALUES env var, yet the value was still seen as a secret. I have not been able to reproduce it but I did notice that in our check we did not make things case-insensitive.

The reason I think this might be necessary is because things like webpack could possibly change the casing of values.

Right now this is the only solution I could think of, apart from adding an additional check if we find a secret, to double check if it is in the omit env var, before we decide to fail the build. I'd rather try this first.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@khendrikse khendrikse requested a review from a team as a code owner October 21, 2025 14:03
@github-actions
Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

Copy link
Contributor

@aitchiss aitchiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh interesting! I guess this makes sense? There is a tiny part of me that feels like if I omit Ls0t123 then ls0t123 shouldn't be omitted... but I think on balance this is a good fix and worth trying 👍

@khendrikse khendrikse merged commit f63e7c2 into main Oct 22, 2025
95 of 98 checks passed
@khendrikse khendrikse deleted the EX-604/fix-secret-scanning-edge-case branch October 22, 2025 13:42
This was referenced Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants