Skip to content

Improve logging of sendStatus CLI flag #1720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2020
Merged

Improve logging of sendStatus CLI flag #1720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/build/src/log/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ const logFlags = function(logs, flags, { debug }) {
// Hidden because the value is security-sensitive
const SECURE_FLAGS = ['token', 'bugsnagKey', 'env', 'cachedConfig', 'defaultConfig']
// Hidden because those are used in tests
const TEST_FLAGS = ['buffer', 'telemetry', 'sendStatus']
const TEST_FLAGS = ['buffer', 'telemetry']
// Hidden because those are only used internally
const INTERNAL_FLAGS = ['nodePath', 'functionsDistDir', 'buildImagePluginsDir']
const INTERNAL_FLAGS = ['nodePath', 'functionsDistDir', 'buildImagePluginsDir', 'sendStatus']
const HIDDEN_FLAGS = [...SECURE_FLAGS, ...TEST_FLAGS, ...INTERNAL_FLAGS]
const HIDDEN_DEBUG_FLAGS = [...SECURE_FLAGS, ...TEST_FLAGS]

Expand Down
24 changes: 24 additions & 0 deletions packages/build/tests/status/snapshots/tests.js.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ Generated by [AVA](https://ava.li).
debug: true␊
deployId: test␊
repositoryRoot: /file/path␊
sendStatus: true␊
testOpts:␊
host: 'localhost:80'␊
scheme: http␊
Expand Down Expand Up @@ -82,6 +83,7 @@ Generated by [AVA](https://ava.li).
debug: true␊
deployId: test␊
repositoryRoot: /file/path␊
sendStatus: true␊
testOpts:␊
host: 'localhost:80'␊
scheme: http␊
Expand Down Expand Up @@ -150,6 +152,7 @@ Generated by [AVA](https://ava.li).
debug: true␊
deployId: test␊
repositoryRoot: /file/path␊
sendStatus: true␊
testOpts:␊
host: 'localhost:80'␊
scheme: http␊
Expand Down Expand Up @@ -234,6 +237,7 @@ Generated by [AVA](https://ava.li).
debug: true␊
deployId: test␊
repositoryRoot: /file/path␊
sendStatus: true␊
testOpts:␊
host: 'localhost:80'␊
scheme: http␊
Expand Down Expand Up @@ -324,6 +328,7 @@ Generated by [AVA](https://ava.li).
debug: true␊
deployId: test␊
repositoryRoot: /file/path␊
sendStatus: true␊
testOpts:␊
host: 'localhost:80'␊
scheme: http␊
Expand Down Expand Up @@ -415,6 +420,7 @@ Generated by [AVA](https://ava.li).
debug: true␊
deployId: test␊
repositoryRoot: /file/path␊
sendStatus: true␊
testOpts:␊
host: 'localhost:80'␊
scheme: http␊
Expand Down Expand Up @@ -493,6 +499,7 @@ Generated by [AVA](https://ava.li).
debug: true␊
deployId: test␊
repositoryRoot: /file/path␊
sendStatus: true␊
testOpts:␊
host: 'localhost:80'␊
scheme: http␊
Expand Down Expand Up @@ -581,6 +588,7 @@ Generated by [AVA](https://ava.li).
debug: true␊
deployId: test␊
repositoryRoot: /file/path␊
sendStatus: true␊
testOpts:␊
host: 'localhost:80'␊
scheme: http␊
Expand Down Expand Up @@ -662,6 +670,7 @@ Generated by [AVA](https://ava.li).
debug: true␊
deployId: test␊
repositoryRoot: /file/path␊
sendStatus: true␊
testOpts:␊
host: 'localhost:80'␊
scheme: http␊
Expand Down Expand Up @@ -1168,6 +1177,7 @@ Generated by [AVA](https://ava.li).
debug: true␊
deployId: test␊
repositoryRoot: /file/path␊
sendStatus: true␊
testOpts:␊
host: 'localhost:80'␊
scheme: http␊
Expand Down Expand Up @@ -1250,6 +1260,7 @@ Generated by [AVA](https://ava.li).
debug: true␊
deployId: test␊
repositoryRoot: /file/path␊
sendStatus: true␊
testOpts:␊
host: 'localhost:80'␊
scheme: http␊
Expand Down Expand Up @@ -1339,6 +1350,7 @@ Generated by [AVA](https://ava.li).
debug: true␊
deployId: test␊
repositoryRoot: /file/path␊
sendStatus: true␊
testOpts:␊
host: 'localhost:80'␊
scheme: http␊
Expand Down Expand Up @@ -1492,6 +1504,7 @@ Generated by [AVA](https://ava.li).
debug: true␊
deployId: test␊
repositoryRoot: /file/path␊
sendStatus: true␊
testOpts:␊
host: 'localhost:80'␊
scheme: http␊
Expand Down Expand Up @@ -1574,6 +1587,7 @@ Generated by [AVA](https://ava.li).
debug: true␊
deployId: test␊
repositoryRoot: /file/path␊
sendStatus: true␊
testOpts:␊
host: 'localhost:80'␊
scheme: http␊
Expand Down Expand Up @@ -1622,6 +1636,7 @@ Generated by [AVA](https://ava.li).
debug: true␊
deployId: test␊
repositoryRoot: /file/path␊
sendStatus: true␊
testOpts:␊
host: 'localhost:80'␊
scheme: http␊
Expand Down Expand Up @@ -1713,6 +1728,7 @@ Generated by [AVA](https://ava.li).
debug: true␊
deployId: test␊
repositoryRoot: /file/path␊
sendStatus: true␊
testOpts:␊
host: 'localhost:80'␊
scheme: http␊
Expand Down Expand Up @@ -1761,6 +1777,7 @@ Generated by [AVA](https://ava.li).
debug: true␊
deployId: test␊
repositoryRoot: /file/path␊
sendStatus: true␊
testOpts:␊
host: 'localhost:80'␊
scheme: http␊
Expand Down Expand Up @@ -1828,6 +1845,7 @@ Generated by [AVA](https://ava.li).
debug: true␊
deployId: test␊
repositoryRoot: /file/path␊
sendStatus: true␊
testOpts:␊
host: 'localhost:80'␊
scheme: http␊
Expand Down Expand Up @@ -1895,6 +1913,7 @@ Generated by [AVA](https://ava.li).
debug: true␊
deployId: test␊
repositoryRoot: /file/path␊
sendStatus: true␊
testOpts:␊
host: 'localhost:80'␊
scheme: http␊
Expand Down Expand Up @@ -2031,6 +2050,7 @@ Generated by [AVA](https://ava.li).
debug: true␊
deployId: test␊
repositoryRoot: /file/path␊
sendStatus: true␊
testOpts:␊
host: 'localhost:80'␊
scheme: http␊
Expand Down Expand Up @@ -2134,6 +2154,7 @@ Generated by [AVA](https://ava.li).
> Flags␊
debug: true␊
repositoryRoot: /file/path␊
sendStatus: true␊
testOpts:␊
host: 'localhost:80'␊
scheme: http␊
Expand Down Expand Up @@ -2240,6 +2261,7 @@ Generated by [AVA](https://ava.li).
debug: true␊
deployId: test␊
repositoryRoot: /file/path␊
sendStatus: true␊
testOpts:␊
host: 'localhost:80'␊
scheme: http␊
Expand Down Expand Up @@ -2346,6 +2368,7 @@ Generated by [AVA](https://ava.li).
debug: true␊
deployId: test␊
repositoryRoot: /file/path␊
sendStatus: true␊
testOpts:␊
host: 'localhost:80'␊
scheme: http␊
Expand Down Expand Up @@ -2503,6 +2526,7 @@ Generated by [AVA](https://ava.li).
debug: true␊
deployId: test␊
repositoryRoot: /file/path␊
sendStatus: true␊
testOpts:␊
host: 'localhost:80'␊
scheme: http␊
Expand Down
Binary file modified packages/build/tests/status/snapshots/tests.js.snap
View file
Open in desktop
Binary file not shown.