Skip to content

Fix crash during error reporting #1723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2020
Merged

Fix crash during error reporting #1723

merged 1 commit into from
Jul 29, 2020

Conversation

@ehmicky
Copy link
Contributor

@ehmicky ehmicky commented Jul 29, 2020

Fixes #1722

The build currently crashes when the following conditions are all met:

  • The build failed
  • The build was run in CI (not locally)
  • The build failed due to a plugin
  • The Build plugin is not a local plugin
  • The Build plugin has no repository field in their package.json

@ehmicky ehmicky added the type: bug code to address defects in shipped code label Jul 29, 2020
@ehmicky ehmicky requested a review from erezrokah July 29, 2020 18:44
@ehmicky ehmicky self-assigned this Jul 29, 2020
@ehmicky ehmicky mentioned this pull request Jul 29, 2020
Closed
@ehmicky ehmicky merged commit 477d832 into master Jul 29, 2020
@ehmicky ehmicky deleted the bug/homepage-reporting branch July 29, 2020 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@erezrokah erezrokah erezrokah approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ehmicky ehmicky

Labels

type: bug code to address defects in shipped code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Crash during error reporting

3 participants

@ehmicky @erezrokah