Skip to content

Refactor timings tests #1732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Refactor timings tests #1732

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 22 additions & 14 deletions packages/build/tests/time/tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,23 +14,18 @@ test('Prints timings to --timersFile', async t => {
try {
await runFixture(t, 'simple', { flags: { timersFile }, snapshot: false })

const timerLines = await getTimerLines(t, timersFile)
t.true(timerLines.every(isTimerLine))
const timerLines = await getTimerLines(timersFile)

timerLines.forEach(({ tag, durationMs }) => {
t.true(isDefinedString(tag))
t.true(isDefinedString(durationMs))
t.true(DURATION_REGEXP.test(durationMs))
})
} finally {
await del(timersFile, { force: true })
}
})

const getTimerLines = async function(t, timersFile) {
const timersFileContent = await pReadFile(timersFile, 'utf8')
return timersFileContent.trim().split('\n')
}

const isTimerLine = function(timerLine) {
const [tag, durationMs] = timerLine.split(' ')
return [tag, durationMs].every(isDefinedString) && DURATION_REGEXP.test(durationMs)
}

const isDefinedString = function(string) {
return typeof string === 'string' && string.trim() !== ''
}
Expand All @@ -42,9 +37,9 @@ test('Prints all timings', async t => {
try {
await runFixture(t, 'plugin', { flags: { timersFile }, snapshot: false })

const timersFileContent = await pReadFile(timersFile, 'utf8')
const timerLines = await getTimerLines(timersFile)
TIMINGS.forEach(tag => {
t.true(timersFileContent.includes(`${tag} `))
t.true(timerLines.some(timerLine => timerLine.tag === tag))
})
} finally {
await del(timersFile, { force: true })
Expand All @@ -60,3 +55,16 @@ const TIMINGS = [
'run_netlify_build.total',
'plugin.onBuild',
]

const getTimerLines = async function(timersFile) {
const timersFileContent = await pReadFile(timersFile, 'utf8')
return timersFileContent
.trim()
.split('\n')
.map(parseTimerLine)
}

const parseTimerLine = function(timerLine) {
const [tag, durationMs] = timerLine.split(' ')
return { tag, durationMs }
}