fix: relative path pattern in workspace globs #5763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhalp
approved these changes
Jul 11, 2024
| await Promise.all( | ||
| patterns.map((pattern) => { | ||
| const matcher = new Minimatch(pattern) | ||
| const cleanedPattern = pattern.replace(/^!?(\.\/)/, (match, p1) => match.replace(p1, '')) |
Member
There was a problem hiding this comment.
maybe leave a comment here explaining why this is needed?
| await Promise.all( | ||
| patterns.map((pattern) => { | ||
| const matcher = new Minimatch(pattern) | ||
| const cleanedPattern = pattern.replace(/^!?(\.\/)/, (match, p1) => match.replace(p1, '')) |
Member
There was a problem hiding this comment.
I wonder if anyone would ever want to use a path starting with ../? 🤔
Contributor
Author
There was a problem hiding this comment.
As it's the root of the workspace I don't think it make any sense
pieh
approved these changes
Jul 11, 2024
Contributor
pieh
left a comment
pieh
left a comment
There was a problem hiding this comment.
I suspect we might encounter some more issues here in the future for other undocumented ways to define workspaces, but this feels at least safe to do, so we might as well get this in to at least cover leading ./ cases that we at least know about
lukasholzer
deleted the
fix/relative-path-pattern-in-workspace-definition
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes the issue where monorepos where not detected properly due to a undocumented feature in pnpm workspace definition.
Fixes https://linear.app/netlify/issue/FRP-774/help-investing-why-monorepo-detection-is-not-working
See https://netlify.slack.com/archives/C01TKAEBP3Q/p1720640110647669
For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)