Skip to content

Conversation

@YujohnNattrass
Copy link
Contributor

🎉 Thanks for submitting a pull request! 🎉

Summary

Follow up to #6008


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@YujohnNattrass YujohnNattrass requested a review from a team as a code owner February 3, 2025 19:25
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

@YujohnNattrass
Copy link
Contributor Author

Tested with Buildbot

deploy

Using the new build image/buildbot:
image

extensions are being fetched properly:
image

@YujohnNattrass YujohnNattrass merged commit 4589f16 into main Feb 11, 2025
32 of 33 checks passed
@YujohnNattrass YujohnNattrass deleted the cpla-2502/remove-ff-for-erroring-builds branch February 11, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants