Skip to content

fix(types): add missing schedule to functions config type #6151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2025
Merged

fix(types): add missing schedule to functions config type #6151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a8a8cf
refactor: remove duplicated type
serhalp Mar 20, 2025
644f53b
fix(types): add missing `schedule` type to function config
serhalp Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/build-info/src/settings/netlify-toml.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,7 @@ export type Functions = {
included_files?: IncludedFiles
node_bundler?: NodeBundler
directory?: Directory
schedule?: string
/**
* Options that only apply for this filter by name, including using glob patterns. If a function matches several configuration blocks containing one of these properties, the values are concatenated.
*/
Expand Down
8 changes: 0 additions & 8 deletions packages/zip-it-and-ship-it/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,6 @@ type ListedFunctionFile = ListedFunction & {
srcFile: string
}

interface ListFunctionsOptions {
Copy link
Member Author

@serhalp serhalp Mar 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see identical type 24 lines below this

basePath?: string
config?: Config
configFileDirectories?: string[]
featureFlags?: FeatureFlags
parseISC?: boolean
}

interface AugmentedFunctionSource extends FunctionSource {
staticAnalysisResult?: StaticAnalysisResult
}
Expand Down
Loading