Skip to content

Conversation

@khendrikse
Copy link
Contributor

🎉 Thanks for submitting a pull request! 🎉

Summary

Netlify CLI/Buildbot uses resolveConfig to get the netlify config. It then starts the build process. During the build process netlify build uses resolveConfig again. It already has the site info at that point though. With this piece of logic we're trying to avoid additional calls to both the netlify api and the extension api. Both of which are happening inside of getSiteInfo.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@khendrikse khendrikse requested a review from a team as a code owner March 20, 2025 14:22
@khendrikse khendrikse force-pushed the cpla-2607/reduce-usage-of-get-site-info branch from dc3cbb0 to 80e00c5 Compare March 20, 2025 14:22
@github-actions
Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

@github-actions
Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

@khendrikse khendrikse merged commit 0ce31e2 into main Mar 21, 2025
33 checks passed
@khendrikse khendrikse deleted the cpla-2607/reduce-usage-of-get-site-info branch March 21, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants