Skip to content

fix: unbreak logs type for buildSite return value #6711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2025
+2 −2
Merged

fix: unbreak logs type for buildSite return value #6711

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/build/src/core/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { trace, context } from '@opentelemetry/api'
import { handleBuildError } from '../error/handle.js'
import { reportError } from '../error/report.js'
import { getLogsOutput, getSystemLogger } from '../log/logger.js'
import type { Logs } from '../log/logger.js'
import type { BufferedLogs } from '../log/logger.js'
import { logTimer, logBuildSuccess } from '../log/messages/core.js'
import { getGeneratedFunctions } from '../steps/return_values.js'
import { trackBuildComplete } from '../telemetry/main.js'
Expand All @@ -27,7 +27,7 @@ const tracer = trace.getTracer('core')
export async function buildSite(flags: Partial<BuildFlags> = {}): Promise<{
success: boolean
severityCode: number
logs: Logs | undefined
logs: BufferedLogs | undefined
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should overall be LogOutput.

Using BufferedLogs here (the difference is optional outputFlusher in BufferedLogs), because that's what was used before #6698 and this is meant to "fix" a type breaking change.

netlifyConfig?: any
configMutations?: any
}> {
Expand Down
Loading